-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A header may be missing for the news blog alternative templates #498
Comments
OK, I found it: header-large-title.php. It does not seem to be used anywhere in the theme. Perhaps someone can remind me if this was a conscious decision. @beafialho @juanfra. |
This header should be a part of the theme, since it gives users an opinionated header layout option to use where they see fit. |
OK, but it is not supposed to be used in these templates by default? If that's the case we don't need to make any other changes |
Let's leave this until last, if there is time left we can look at it then. |
@carolinan I can take a shot at it! |
This is not as simple as it may appear, and there are valid reasons not to do it. Creating a full set of templates increases the number of files and designs to maintain, and makes the theme more difficult to use. Without a way to apply the entire template set across the site, switching all the templates starts to get overwhelming. |
It's already kind of confusing since the theme is basically 1 parent theme and multiple child themes in one. |
In Figma some of the news blog templates have a vertical menu, not horizontal.
This design and this header is not part of the theme.
If this is correct, can the Figma files please be updated so that more time is not spent on it?
I don't mind how the vertical menu looks. But I am concerned that if it is implemented, it will only work as long as the user keeps the menu short.
It is not possible for the theme or the block to limit the number of menu items.
News blog with featured posts grid
News blog with sidebar
Left-aligned content
The text was updated successfully, but these errors were encountered: