Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A header may be missing for the news blog alternative templates #498

Open
carolinan opened this issue Oct 4, 2024 · 8 comments
Open

A header may be missing for the news blog alternative templates #498

carolinan opened this issue Oct 4, 2024 · 8 comments
Assignees
Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Question Questions about the design or development of the theme.

Comments

@carolinan
Copy link
Contributor

carolinan commented Oct 4, 2024

In Figma some of the news blog templates have a vertical menu, not horizontal.
This design and this header is not part of the theme.
If this is correct, can the Figma files please be updated so that more time is not spent on it?

I don't mind how the vertical menu looks. But I am concerned that if it is implemented, it will only work as long as the user keeps the menu short.
It is not possible for the theme or the block to limit the number of menu items.

News blog with featured posts grid
Image

News blog with sidebar
Image

Left-aligned content
Image

@carolinan carolinan added [Status] Needs Design Feedback Needs general design feedback. [Type] Question Questions about the design or development of the theme. Needs Figma Update Needs an update to Figma for design purposes labels Oct 4, 2024
@carolinan
Copy link
Contributor Author

OK, I found it: header-large-title.php. It does not seem to be used anywhere in the theme. Perhaps someone can remind me if this was a conscious decision. @beafialho @juanfra.

@beafialho
Copy link
Contributor

This header should be a part of the theme, since it gives users an opinionated header layout option to use where they see fit.

@carolinan
Copy link
Contributor Author

carolinan commented Oct 4, 2024

OK, but it is not supposed to be used in these templates by default? If that's the case we don't need to make any other changes than adding it to theme.json.

@carolinan carolinan removed [Status] Needs Design Feedback Needs general design feedback. Needs Figma Update Needs an update to Figma for design purposes labels Oct 4, 2024
@beafialho
Copy link
Contributor

It was intended to be used in these 3 templates by default. I can't exactly recall why it wasn't added in the first place.

Image

@carolinan
Copy link
Contributor Author

Let's leave this until last, if there is time left we can look at it then.

@carolinan carolinan added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Oct 7, 2024
@kirtangajjar
Copy link
Member

@carolinan I can take a shot at it!

@carolinan
Copy link
Contributor Author

This is not as simple as it may appear, and there are valid reasons not to do it.
Just like with the vertical header, if this is created into a template part to be used as the default, the end result is going to be confusing for the visitor of the site unless there is a complete set of templates.
Otherwise you end up with home having one header, 404 another, and single posts a third header, which makes it dififcult to navigate the site.

Creating a full set of templates increases the number of files and designs to maintain, and makes the theme more difficult to use.

Without a way to apply the entire template set across the site, switching all the templates starts to get overwhelming.

@carolinan
Copy link
Contributor Author

It's already kind of confusing since the theme is basically 1 parent theme and multiple child themes in one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Question Questions about the design or development of the theme.
Projects
None yet
Development

No branches or pull requests

3 participants