Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midnight: List of elements to adjust #549

Open
beafialho opened this issue Oct 10, 2024 · 1 comment · May be fixed by #563
Open

Midnight: List of elements to adjust #549

beafialho opened this issue Oct 10, 2024 · 1 comment · May be fixed by #563
Assignees
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@beafialho
Copy link
Contributor

While testing the Midnight variation and its typography preset, I noticed some elements could be improved:

Image
Image

Here are the changes that can improve the look of the variation & typeset:

  • Post Author Name: reset styles
  • Post Terms: reset styles
  • Font size preset XXL: min 2rem, max 2.8rem
  • Font size preset XL: min 1.8rem, max 2.2rem
  • Font size preset L: min 1.2rem, max 1.8rem
  • Font size preset M: min 0.9rem, max 1.2rem
  • Font size preset S: 0.9rem
  • Text: set to font size preset M, letter spacing -0,01em, line height 1.5
  • Quote: reset font size (it should use the same preset as Text)
  • Pullquote: remove specific line height
  • Headings: line height 1.24
  • H6: remove specific font-weight (it should be the same as other headings, 300)
  • Buttons: set to font size preset M, font-weight: 400, letter spacing -0.01em
  • If it’s possible, can we remove Fira Sans Bold from the theme and whenever the Bold typography setting is selected and applied, it falls back to Fira Sans Medium? Mostly because Fira Sans Bold is appearing a bit harsh visually, probably because there’s no font smoothing, like there is on Figma.

How it's expected to look with the changes applied.

Image
Image
Image
Image

@beafialho beafialho added the [Type] Enhancement A suggestion for improvement. label Oct 10, 2024
@carolinan
Copy link
Contributor

If it’s possible, can we remove Fira Sans Bold from the theme and whenever the Bold typography setting is selected and applied, it falls back to Fira Sans Medium? Mostly because Fira Sans Bold is appearing a bit harsh visually, probably because there’s no font smoothing, like there is on Figma.

Interesting question; yes it can be removed, I am not sure what it will fall back to 🤔

@juanfra juanfra linked a pull request Oct 11, 2024 that will close this issue
@juanfra juanfra self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants