Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session time input changes time unexpectedly #1385

Open
ryelle opened this issue Oct 4, 2024 · 1 comment · May be fixed by #1394
Open

Session time input changes time unexpectedly #1385

ryelle opened this issue Oct 4, 2024 · 1 comment · May be fixed by #1394
Assignees
@ryelle
Labels
[Component] WC-Post-Types Organizers, Speakers, Sessions, Schedule, Sponsors, Volunteers [Type] Bug

Comments

@ryelle
Copy link
Contributor

ryelle commented Oct 4, 2024

The session time input is not working correctly, something is causing it to jump around while entering times. This appears to only happen if the session is after daylight saving time ends.

In the video, you can see the number is skipping down by two despite me only hitting the down arrow once. Then I hit up, and it doesn't always change. Moving over to toggle AM/PM, the time also changes. Back to the input, entering 12 automatically updates to 11.

ScreenFlow.mp4

Video recorded on MacOS + firefox.

Thanks to platcatheo for reporting this in Slack.
@ryelle ryelle added [Component] WC-Post-Types Organizers, Speakers, Sessions, Schedule, Sponsors, Volunteers [Type] Bug labels Oct 4, 2024
@ryelle ryelle self-assigned this Oct 4, 2024
@ryelle
Copy link
Contributor Author

ryelle commented Oct 8, 2024

This is to do with how the timezone offset is calculated, as a fixed amount for a given location rather than date-aware (for example, if the timezone is America/New_York, it's calculated as -04:00, even though in December it would actually be -05:00). This is complicated by the fact that the site timezone and browser timezone can be different.

ryelle added a commit that referenced this issue Oct 11, 2024
@ryelle
WC Post Types: Fix timezone offset when sessions happen after DST
04070eb 
This change updates how the session dates are converted when the site and client timezones are different. Rather than creating a fixed timezone offset on page load, this converts the times into the server timezone for the given date — this way, the offset is correctly applied if a future date is in a different timezone (DST starts or ends).

Fixes #1385
@ryelle ryelle linked a pull request Oct 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryelle ryelle

Labels
[Component] WC-Post-Types Organizers, Speakers, Sessions, Schedule, Sponsors, Volunteers [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WC Post Types: Fix timezone offset when sessions happen after DST WordPress/wordcamp.org
1 participant
@ryelle