Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsor Block: Improve help text for order by control #41

Closed
vedanshujain opened this issue Mar 25, 2019 · 0 comments
Closed

Sponsor Block: Improve help text for order by control #41

vedanshujain opened this issue Mar 25, 2019 · 0 comments
Assignees
Milestone

Comments

@vedanshujain
Copy link
Contributor

Select whether to sort by name or sponsor level.

This part seems redundant, since it's obvious from the options in the dropdown.

Order of sponsor level can be configure by going to Sponsor -> Order Sponsor Levels admin menu.') }

Can we provide a direct link here, or does Gutenberg only allow text? If it's the latter, it might be good to open an issue suggesting they allow links for this type of use case.

We could probably also make this more succinct in order to make it easier to skim, and clutter the UI less. Maybe something like,

Configure sponsor levels.

...if a link is possible. It should probably open in a new tab, as much as i hate that.

Or,

Configure sponsor levels from the Sponsor -> Order Sponsor Levels page.

...if a link isn't if possible.

Originally posted by @iandunn in #33

vedanshujain added a commit that referenced this issue Mar 27, 2019
In `Order By` sponsor level control, help text has a bit of redundant instruction which is already implied by the SelectControl label.
This fixes #41
@iandunn iandunn added this to the Blocks v1 milestone Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants