Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for json linter failures created by the CMS #61

Open
2 tasks
coilysiren opened this issue Jun 26, 2019 · 1 comment
Open
2 tasks

Add handling for json linter failures created by the CMS #61

coilysiren opened this issue Jun 26, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@coilysiren
Copy link
Member

Description

The CMS produces json files that don't match the way prettier wants our json to be formatted. We would like to keep linting all our json files with prettier, so we need to have prettier run on the CMS output.

Why this is valuable:

Linting json files is good for collaboration ✨ The content files in may end up being high churn (and edited via both the CMS - and via clis / text editors), so its particularly useful to have linting active there.

Acceptance Criteria

  • content is removed from .prettierignore
  • new json files created by the CMS don't fail linting

Ideas

There's two primary avenues here:

  • you lint pre-commit via some sort of hook in the CMS
  • you lint post-push via a github hook
@deweydell deweydell added the bug Something isn't working label Sep 28, 2019
@deweydell
Copy link
Contributor

I wonder if we can use github actions to run prettier on CMS PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants