Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better configuration system #41

Open
ylt opened this issue Jun 30, 2015 · 4 comments
Open

Better configuration system #41

ylt opened this issue Jun 30, 2015 · 4 comments

Comments

@ylt
Copy link
Member

ylt commented Jun 30, 2015

No description provided.

@ylt ylt added the ready label Jun 30, 2015
@ylt ylt self-assigned this Jun 30, 2015
@ylt
Copy link
Member Author

ylt commented Jun 30, 2015

https://www.npmjs.com/package/config
Great quality, it's missing saving and reloading however

https://www.npmjs.com/package/hi-config
Has saving and reloading, but problems are that it has no github repository (despite being "MIT" licensed) and the property storage is flat.

Rest of the node modules were even more lacking, so have to write one mostly written from scratch. Considering taking the useful parts out of node-config and expanding the remainder in order to get clean two-way saving.

Would be nice to have internal isolation between "defaults" and actual configured settings. Maybe most flexible approach would be to make a single file loader class, and then make another class capable of accessing multiple nested config classes within (in failover).

@pironic
Copy link
Member

pironic commented Jul 3, 2015

how is this different from #42?

@ylt
Copy link
Member Author

ylt commented Jul 3, 2015

This is for user configuration (plug username, password, etc), #42 is plugin configuration

@ylt
Copy link
Member Author

ylt commented Jul 4, 2015

Allow retrieving shared configs - this would be useful in order to implementing basicbot.
eug3gml

Might be worth investigating if the config system itself can be made flexible such as allowing a file per plugin, or using a database - with the design I have in mind, it won't be much of an extension but will have to be thought out ahead of time to save having to redo parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants