Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New event system #47

Open
ylt opened this issue Jul 11, 2015 · 1 comment
Open

New event system #47

ylt opened this issue Jul 11, 2015 · 1 comment

Comments

@ylt
Copy link
Member

ylt commented Jul 11, 2015

Current approach is a bit of a hack, especially in terms of how it's a nested object with the this scope of parent.

Should use a more typical approach, probably implement a plugininst.on("event_name", func). This would have the benefit of being able to optimise events and would make it easier to implement prioritisation (issue #20).

@ylt
Copy link
Member Author

ylt commented Aug 10, 2015

Progress towards this has been made using decorations (part of #56).

This still needs implementing, but the decorations can be modified to use this approach internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant