Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better npm support #52

Open
ylt opened this issue Jul 22, 2015 · 0 comments
Open

Better npm support #52

ylt opened this issue Jul 22, 2015 · 0 comments

Comments

@ylt
Copy link
Member

ylt commented Jul 22, 2015

Two issues, can be solved in one go:

  1. npm should manage the project as a whole rather than automating it for each plugin. This allows npm features such as dedupe to work
  2. Wallace should scan for npm modules that list a compatible wallace version as a peer dependency, these can be loaded directly rather than from the directory.

Rather than having a npm postinstall script go through all the plugin folders, it would probably be better to list out the plugins needing dependencies in the package.json. npm should then copy the plugins from the plugin directory into the node_modules.

The old folder loading code can be kept, but plugins loaded this way will not have their npm dependencies installed automatically anymore.

If an identical npm module is found to one that's in a plugin folder, prioritise the npm module unless the bot is in dev mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant