Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProfileKeys incorrectly being created for alts #1068

Open
3 tasks done
ThisTestUser opened this issue Oct 4, 2024 · 1 comment · May be fixed by #1069
Open
3 tasks done

ProfileKeys incorrectly being created for alts #1068

ThisTestUser opened this issue Oct 4, 2024 · 1 comment · May be fixed by #1069
Labels
status:never-stale Prevents stalebot from marking this item as stale. type:bug Something isn't working

Comments

@ThisTestUser
Copy link
Contributor

ThisTestUser commented Oct 4, 2024

Pre-reporting checklist

  • I have searched existing issues and didn't find any previous reports of this bug.
  • This bug still happens in the latest version of Wurst. I've made sure my installation is up to date.
  • I have tried removing all other mods and the bug still happens.

Description

Right now, ProfileKeys is created whenever an alt is selected, even if the alt is cracked (https://github.com/Wurst-Imperium/Wurst7/blob/master/src/main/java/net/wurstclient/mixin/MinecraftClientMixin.java#L220). This doesn't cause any issues in game, besides an error message that shows up every time a server is joined.

#1069 fixes this.

Repro steps

  1. Switch to a cracked alt via AltManager.
  2. Login to any server.
  3. See the below error message in logs:
Failed to retrieve profile key pair
com.mojang.authlib.exceptions.MinecraftClientHttpException: Status: 401
	at com.mojang.authlib.minecraft.client.MinecraftClient.readInputStream(MinecraftClient.java:100) ~[authlib-6.0.54.jar:?]
	at com.mojang.authlib.minecraft.client.MinecraftClient.post(MinecraftClient.java:65) ~[authlib-6.0.54.jar:?]

Wurst Client version

7.46

Minecraft version

1.21.1

Crash report (if applicable)

No response

@ThisTestUser ThisTestUser added status:unconfirmed New issue. Needs triage. type:bug Something isn't working labels Oct 4, 2024
@Alexander01998
Copy link
Member

Thanks for the explanation and repro steps! I'll look into it.

@Alexander01998 Alexander01998 added status:never-stale Prevents stalebot from marking this item as stale. and removed status:unconfirmed New issue. Needs triage. labels Oct 4, 2024
@ThisTestUser ThisTestUser linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:never-stale Prevents stalebot from marking this item as stale. type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants