Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider transverse diffusion treatment at the interface #162

Open
ramirezdiego opened this issue Mar 18, 2024 · 1 comment
Open

Reconsider transverse diffusion treatment at the interface #162

ramirezdiego opened this issue Mar 18, 2024 · 1 comment

Comments

@ramirezdiego
Copy link
Collaborator

Right now we smear our S2 pattern map according to transverse diffusion, via s2_pattern_map_diffuse, where we redefine our S2 pattern for it to account for this diffussion. This means that we treat the electron cloud at the interface as a point, apply the extraction efficiency for that XY, and later on effectively correct for diffusion at the PMT pattern level.

The alternative (more physically correct approach) is to get rid of this function and apply the transverse diffusion at the interface, such that the extraction efficiency per electron is better applied and we do not need corrections for the pattern map.

@ramirezdiego
Copy link
Collaborator Author

(The bad side of this implementation is that we apply a per-electron treatment earlier in the pipeline, which impacts both memory and speed of the code.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant