Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused plugin dependencies #96

Open
ramirezdiego opened this issue Jan 10, 2024 · 4 comments
Open

Remove unused plugin dependencies #96

ramirezdiego opened this issue Jan 10, 2024 · 4 comments

Comments

@ramirezdiego
Copy link
Collaborator

As pointed out by @HenningSE, some of the unused plugin dependencies in the WFSim->fuse transition went under the radar in the review of #72. Before the next release, make sure to clean up the code of these dependencies.

Related to this: let's also clean up the deprecated options in the config *json files.

@dachengx
Copy link
Contributor

dachengx commented Feb 2, 2024

If we want to deprecate the options in the config *json file, we should not run the function AxFoundation/strax#800 provides. Because the new function will automatically purge unused configs and stop showing warnings.

@HenningSE
Copy link
Collaborator

I think this issue has basically two parts:

  • Check again all URLConfigs for all plugins. Remove the ones that are not used in the code.
  • Build a new simulation config that just has the values we actually care about and use.

@ramirezdiego
Copy link
Collaborator Author

I'll start a PR for a fuse-only config file (was actually the initial target of this issue, but posponed), let's clean up from there 👍

@mhliu0001
Copy link
Contributor

I have this autogenerated table of all the configs currently needed in fuse, if anyone is interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants