Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload cached corrections and to-download info #151

Open
FaroutYLq opened this issue May 31, 2024 · 7 comments
Open

Upload cached corrections and to-download info #151

FaroutYLq opened this issue May 31, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request PRIORITY wontfix This will not be worked on

Comments

@FaroutYLq
Copy link
Collaborator

Triggered by discussion here. The concern is currently outsource is occupying too many DB connection, endangering DB service. We need to deeply understand where DB is called first.

@FaroutYLq FaroutYLq added the enhancement New feature or request label May 31, 2024
@FaroutYLq
Copy link
Collaborator Author

Assuming we have to live with 5k cap, we basically can only have 30% at most for our full computational power.

@FaroutYLq
Copy link
Collaborator Author

We observed >8 connection for a typical already before making. Something need to be improved here, which is basically initialized and not really used until we call related DB operation.

@rsriya
Copy link
Contributor

rsriya commented Sep 27, 2024

Isn't this issue solved by this PR - XENONnT/utilix#122?

@FaroutYLq
Copy link
Collaborator Author

Isn't this issue solved by this PR - XENONnT/utilix#122?

@rsriya I am not sure it fully solves the story. I would say at least it helps.

@dachengx
Copy link
Contributor

dachengx commented Oct 4, 2024

Isn't this issue solved by this PR - XENONnT/utilix#122?

It is not totally solved by that. But it can help a bit.

@dachengx
Copy link
Contributor

dachengx commented Oct 4, 2024

We observed >8 connection for a typical already before making. Something need to be improved here, which is basically initialized and not really used until we call related DB operation.

This PR will reduce the connection: XENONnT/admix#59.

But I am worrying about the too-large discrepancy between the master and stable branch of admix, which might result in another round of cleaning after we merge them.

@dachengx dachengx added the wontfix This will not be worked on label Oct 15, 2024
@dachengx
Copy link
Contributor

I marked this PR as wontfix because the less DB connection after XENONnT/admix#59 is expected.

And it could be dangerous if we download and upload the corrections maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PRIORITY wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants