Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod Support]: Building Gadgets #366

Open
gus3000 opened this issue Jan 18, 2024 · 2 comments
Open

[Mod Support]: Building Gadgets #366

gus3000 opened this issue Jan 18, 2024 · 2 comments
Assignees
Labels

Comments

@gus3000
Copy link

gus3000 commented Jan 18, 2024

The mod to integrate with

https://github.com/Direwolf20-MC/BuildingGadgets

Describe the feature

This issue has been raised in the past (2021):

With the following versions :

  • FramedBlocks : 9.1.6
  • Building Gadgets 2 : 1.0.6
  • Forge : 47.2.19

Using the copy-paste tool, the framed blocks are only partially correctly copied.

Here is the structure I'm copying :
2024-01-18_17 15 55
It makes heavy usage of Framed Collapsible Blocks for the slopes, and a single Framed Slope.

And here is the pasted result :
2024-01-18_17 16 06

As you can see, the Framed Collapsible Blocks are copied, but with no data.
The Framed Slope is however correctly oriented.
All the framed blocks are lacking their affected appearance block.

Did FramedBlocks and Building Gadgets support each other in the past, and somewhere along the updates compatibility broke, or does the full integration require additional work on top of what you did in 2021 ?

Best regards.

EDIT : upon further inspection, the Building Gadgets 1 and 2 utilize separate code bases (https://github.com/Direwolf20-MC/BuildingGadgets and https://github.com/Direwolf20-MC/BuildingGadgets2), so this is probably due to a difference in implementation. I'll open an issue on their new repo

@gus3000 gus3000 added enhancement New feature or request mod support labels Jan 18, 2024
@XFactHD XFactHD added the 1.20 label Jan 18, 2024
@XFactHD
Copy link
Owner

XFactHD commented Jan 18, 2024

FramedBlocks has full integration with Building Gadgets 1 and to my knowledge that integration still works fine.
Building Gadgets 2 is a complete rewrite of the mod. In the current state it's still missing the necessary systems to allow me to copy the data that's gone missing in your screenshot. As such there is currently nothing I can do about this.
I will leave this issue open for the time being with the hope of bringing back integration with BG2.

@gus3000
Copy link
Author

gus3000 commented Jan 18, 2024

Thank you for your quick answer, I created an issue on the Building Gadgets 2 repo, we'll have to wait and see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants