Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protector -> Legacy XoopsDB is deprecated since 2.6.0 #368

Open
slider84 opened this issue Jul 24, 2015 · 1 comment
Open

Protector -> Legacy XoopsDB is deprecated since 2.6.0 #368

slider84 opened this issue Jul 24, 2015 · 1 comment

Comments

@slider84
Copy link

In debugbar:
Legacy XoopsDB is deprecated since 2.6.0; all calls should be using Doctrine through $xoops->db(). Called from query() in ROOT/modules/protector/admin/index.php line 30

@geekwright
Copy link
Contributor

Protector needs to be refactored, and is on the radar. I've been holding off until a couple of other things that will also require changes are implemented. It will continue to need to use legacy hooks to protect legacy code, which will also trigger deprecation warnings. The new DBAL based access uses bound parameters, and take prevents many of the SQL based attacks that Protector has traditionally prevented.

Only one deprecated message will be generated per run, but it will nag us by design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants