Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage1 mvp batch dimension #269

Closed
wants to merge 118 commits into from

Conversation

ryk-wolf
Copy link
Contributor

@ryk-wolf ryk-wolf commented Aug 4, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Ensure that code and tests are properly formatted, by running make format or black -l 100 <filename> on any relevant files. You will need to have the Black code format installed:
    pip install black.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • The Mr Mustard source code conforms to
    PEP8 standards except line length.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint mrmustard/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@sylviemonet sylviemonet marked this pull request as ready for review September 7, 2023 22:15
@elib20 elib20 marked this pull request as draft September 8, 2023 14:22
@elib20
Copy link
Contributor

elib20 commented Sep 8, 2023

Just switched this to draft until some issues get resolved

@ziofil ziofil marked this pull request as ready for review September 19, 2023 15:58
@ziofil ziofil closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants