Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify persist #86

Open
XeroOl opened this issue Jul 19, 2022 · 1 comment
Open

Simplify persist #86

XeroOl opened this issue Jul 19, 2022 · 1 comment
Assignees
Labels
discussion Ideas that I'm not yet sure about adding, but would like to hear your thoughts on enhancement New feature or request wontfix This will not be worked on
Milestone

Comments

@XeroOl
Copy link
Owner

XeroOl commented Jul 19, 2022

For func, and also for perframe and func_ease. perframe and func_ease are slightly different.

New Behavior
persist=
When true (default), the function will always be called.
When false, the function will only be called if at least one frame has happened before beat.
When its a number, the function will only be called if at least one frame has happened before beat + persist.
(The function is always guaranteed to run in gameplay, but will be skipped in the editor if the part being played is more than persist away from the func)

Current Behavior
When true (default), the function will always be called.
When false, the function will only be called when a frame happens between beat and beat + 0.5.
When its a number, the function will only be called when a frame happens between beat and beat + persist.
(The function is guaranteed to either run between beat and beat + persist, or not at all)

@XeroOl XeroOl added the enhancement New feature or request label Jul 19, 2022
@ChocoboGamer ChocoboGamer added this to the 6.0.0 rc1 milestone Sep 25, 2022
@XeroOl XeroOl changed the title New persist semantics! Simplify persist May 20, 2023
@XeroOl XeroOl added the wontfix This will not be worked on label May 20, 2023
@XeroOl
Copy link
Owner Author

XeroOl commented May 21, 2023

I don't believe there is high demand for this, so it is probably not worth the effort. If anyone was looking forward to this feature in v6, please let me know because right now I think this will get skipped

@XeroOl XeroOl added the discussion Ideas that I'm not yet sure about adding, but would like to hear your thoughts on label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Ideas that I'm not yet sure about adding, but would like to hear your thoughts on enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants