Fix (llm): fix device issue for eval when not using default device #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing. Is this because of the PR? |
|
Is this still relevant/needed? |
yes, still needed. We applied it manually on the separate branch |
fabianandresgrob
force-pushed
the
fix/device_llm_quant
branch
from
fb191f7
to
89aeaad
Compare
Giuseppe5
reviewed
May 28, 2024
fabianandresgrob
force-pushed
the
fix/device_llm_quant
branch
from
89aeaad
to
3c4a674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem when setting a different device than the default. E.g. when
cuda:0is free, the call tocuda()would place the data on that device. However, when we specified the model to be oncuda:1, we run into the problem of having the data on a different device than the model. Simply moving the data tomodel.devicesolves this. For the creation of a validation_dataloader, I've added an argument to solve this issue.