Avoid test conflicts between peano and chess #1617
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenneuendorffer
force-pushed
the
tests
branch
from
48c8827
to
e96e618
Compare
stephenneuendorffer
requested review from
AndraBisca,
fifield and
makslevental
as code owners
fifield
approved these changes
Jul 22, 2024
stephenneuendorffer
force-pushed
the
tests
branch
from
96924a6
to
4a13f81
Compare
stephenneuendorffer
requested review from
jgmelber and
jackl-xilinx
as code owners
Basically there are two kinds of tests: 1) tests which can use either compiler 2) tests which specifically use one or the other We need to be careful in the second case to not mix the two compilers.
There was a test for this, but it wasn't getting run.
stephenneuendorffer
force-pushed
the
tests
branch
from
4a13f81
to
b749b3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically there are two kinds of tests:
We need to be careful in the second case to not mix the two compilers.