Iterating Map

[3096]

Iterating maps is unnecessary and a loss of performance, especially if a map size gets large.

For this example:

Plutonium/Plutonium/Source/pu/ui/render/render_SDL2.cpp

Lines 35 to 38 in 0fefac2

	for(auto font: shfonts)
	{
	if((font.first == Size) && (font.second.first == Type)) return font.second.second;
	}

Consider something like:

auto foundItr = shfonts.find(Size);
if (foundItr != shfonts.end() && foundItr->first == Type) return foundItr->second;

[3096]

Unordered map can be used for constant time access, and even ordered map is logarithmic time.

[3096]

Same applies to arrays like:

Plutonium/Plutonium/Source/pu/ui/elm/elm_Menu.cpp

Lines 411 to 415 in 0fefac2

	if(!this->itms.empty()) for(s32 i = 0; i < this->itms.size(); i++)
	{
	if(i == this->isel) this->selfact = 0;
	else if(i == this->previsel) this->pselfact = 255;
	}

This code is essentially checking if this->isel and this->previsel (whatever those are) are in range of 0 to itms.size(), no need to iterate. (It also should always be in range?)