Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdrs async open can cause memory leak #129

Open
fMeow opened this issue Mar 19, 2024 · 2 comments
Open

hdrs async open can cause memory leak #129

fMeow opened this issue Mar 19, 2024 · 2 comments

Comments

@fMeow
Copy link
Contributor

fMeow commented Mar 19, 2024 •
edited
Loading

Change async_open back to open massively reduce memory usage. Invesigating.

  • updated (2024.03.23)
    Setting log level to TRACE, I foundhdrs::File instances correctly dropped. And I tried offload hdrs file reading operation to avoid blocking on async runtime via tokio::task::spawn_blocking and it works like a charm. So it is highly possible that the underlying blocking mechanism currently at use is at fault.
@Xuanwo
Copy link
Owner

Xuanwo commented Mar 21, 2024

Maybe related to blocking::Unblock?

@fMeow
Copy link
Contributor Author

fMeow commented Mar 23, 2024

Agree, though I don't have evidence. Maybe Unblock does not correctly free memories of data that passed back to original async runtime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuanwo @fMeow