Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Static context not reflected in request's context #1376

Closed
aljimenez opened this issue May 28, 2014 · 4 comments
Closed

Static context not reflected in request's context #1376

aljimenez opened this issue May 28, 2014 · 4 comments

Comments

@aljimenez
Copy link
Contributor

The context defined at start up time is not reflected per request. For example if the environment is set to "development" at startup, I would expect req.context.environment to be equal to "development" unless that request overwrites the environment dimension. Instead req.context.environment remains undefined. The mojito-contextualizer middleware should mix the static context to the request's context, giving the request's context precedence.

@aljimenez aljimenez changed the title Static context not passed to request's context Static context not reflected in request's context May 28, 2014
@drewfish
Copy link
Contributor

I totally agree. This caused me trouble when I was writing an app with Mojito, and I wound up implementing my own contextualizing middleware that did just this.

@aljimenez
Copy link
Contributor Author

Ok, I can fix it; it should be an easy fix. Just wanted to make sure this wasn't by design.

@aljimenez
Copy link
Contributor Author

Pull request #1378

@moeinnb76
Copy link

#1377

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants