Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuation not consistent for M19 (Text Summarization with Pretrained Encoders) #7

Open
artidoro opened this issue Sep 29, 2020 · 3 comments

Comments

@artidoro
Copy link

artidoro commented Sep 29, 2020

It appears that there are no periods at the end of summaries (and possibly also sentences) in the outputs of bertsumextabs.

Is this a feature of the model?
Could this impact the reported scores if it's a preprocessing/postprocessing error?

@artidoro
Copy link
Author

Verifying with the original output: https://github.com/nlpyang/PreSumm, it seems like the model uses <q> tokens for separation between sentences in the decoded outputs.

So this seems to be problem in the processing of the model outputs which could affect the scores you report.

@artidoro
Copy link
Author

artidoro commented Oct 7, 2020

I found a temporary solution: the double space seems to be indicating the missing period.

@Alex-Fabbri
Copy link
Contributor

Alex-Fabbri commented Oct 25, 2020

Hi, thank you for pointing it out! And sorry for the delay in following up. You are correct that the double space corresponds to the missing period. It looks like the file we received for that model was without the period. For the reported scores, we use bertsum-abs, so this doesn't affect the tables, but I will follow up to insert the periods in those files.

@Yale-LILY Yale-LILY deleted a comment from Rumi4 Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants