Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crontab install doesn't honor tracked repo metadata excludes #44

Open
sp3nx0r opened this issue Jan 22, 2020 · 1 comment
Open

Crontab install doesn't honor tracked repo metadata excludes #44

sp3nx0r opened this issue Jan 22, 2020 · 1 comment

Comments

@sp3nx0r
Copy link
Contributor

sp3nx0r commented Jan 22, 2020

for repo, is_local in list_tracked_repositories(args):
command = '{} detect-secrets-server scan {}'.format(
repo['crontab'],
repo['repo']
)
if is_local:
command += ' --local'
if args.root_dir:
command += ' --root-dir {}'.format(args.root_dir)
if args.output_hook_command:
command += ' {}'.format(args.output_hook_command)
jobs.append(command.strip())

Code currently doesn't honor tracked repo metadata, which makes installing a cronjob with that data manual. Adding placeholder to come back and fix this

@sp3nx0r
Copy link
Contributor Author

sp3nx0r commented Jan 22, 2020

This is only an issue if the fix for Issue #17 isn't in play. Remaining args will be picked up from metadata.

@sp3nx0r sp3nx0r changed the title Crontab install doesn't honor tracked repo metadata, only CLI args Crontab install doesn't honor tracked repo metadata excludes Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant