Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between easy_prime web output and cli output #5

Open
marcus-r-kelly opened this issue Jan 17, 2023 · 2 comments
Open

Discrepancy between easy_prime web output and cli output #5

marcus-r-kelly opened this issue Jan 17, 2023 · 2 comments

Comments

@marcus-r-kelly
Copy link

Thank you for this excellent tool!

I am wondering about a discrepancy I find between the webtool and a local install.
Specifically, submitting the following variant:

  • Chromosome : chr12
  • Position : 25398281
  • Reference : CCACCA
  • Alternative : CCAACG

Produces different efficiency estimates with the tool as installed by conda following the directions.
Specifically, the best solution in both cases is this :
image
But the installed efficiency estimate is 0.47. Is the command-line tool given out of 1.0 instead of 100%? Are there other reasons these should be so different?

@YichaoOU
Copy link
Owner

Thanks!

Yes, the predicted_efficiency in topX_pegRNAs.csv is from 0 to 1. If you multiply it by 100, you have the percentage.

I'm not sure why, even though they gave the same pegRNA, the predicted efficiency is different. When I used the local version, I also got 0.47004926204681396.

One thing I want to mention is that, for the vcf format, I would assume there is no overlap between ref and alt. Right now, your ref is CCACCA and your alt is CCAACG, I think it should CCA and ACG. The beginning CCA should be removed because these positions are unchanged. And then the Position becomes 25398281+3.

@marcus-r-kelly
Copy link
Author

marcus-r-kelly commented Jan 31, 2023

One thing I want to mention is that, for the vcf format, I would assume there is no overlap between ref and alt. Right now, your ref is CCACCA and your alt is CCAACG, I think it should CCA and ACG. The beginning CCA should be removed because these positions are unchanged. And then the Position becomes 25398281+3.

I have sanitized my variants and this fixed an entirely unrelated issue where command-line easyprime would produce pegRNAs encoding indels not described in the input variants. However, it did not change the discrepancy between the webtool and the command line utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants