Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data file override #1

Open
Yisoong opened this issue Nov 15, 2024 · 1 comment
Open

Data file override #1

Yisoong opened this issue Nov 15, 2024 · 1 comment

Comments

@Yisoong
Copy link
Owner

Yisoong commented Nov 15, 2024

Deleting a " from the last line of stored data causes the program to fail to detect the data file upon next start up

Steps to recreate:

  1. Add events to the list
  2. Exit the program
  3. Open the data file and delete the last "
  4. Close the data file
  5. Start the app
  6. List will show no items in list and data file will be reset

Expected: Only the last line will be deleted as it is not in quotation marks
Actual: Whole file's data is deleted

Before
image.png

Change
Screenshot 2024-11-15 at 16.52.25.png

After
Screenshot 2024-11-15 at 16.47.48.png

@nus-pe-bot
Copy link

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for noting this.

The UG states "Direct amendment from the data.txt file is not recommended to prevent data from being lost due to incorrect detail inputs." and "All fields added to data.txt must also be enclosed within double quotation marks (" ") to be properly parsed."

Intentionally editing the txt file to do something that is rejected by the app itself should be considered under "extreme user behaviour" as it is "deliberate sabotage". Also, this will affect minimal users, since not many users are going to go to the txt file to specifically remove a single quotation mark.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your reason]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants