Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

LIN-623 Fix keyphrase in slug researcher for compound keyphrases with hyphens #19

Closed

Conversation

bintzandt
Copy link
Contributor

Summary

This PR can be summarized in the following changelog entry:

  • Fixes the bug when a compound keyphrase with a hyphen would not be recognized in the slug.

Relevant technical choices:

  • The currently implemented algorithm splits a compound word in two and thus counts it as two separate words. So the keyphrase awesomest video-games would be treated as three separate words in the keyphraseInSlug assessment (awesomest, video and games) and matching just video-games in a slug would be enough to score a green bullet.

Test instructions

This PR can be tested by following these steps:

  • Check if keyphrases with hyphens are correctly recognized in the slug
  • Try combining words with and without hyphens in the keyphrase and see if they are correctly recognized in the slug
  • Check if keyphrases without hyphens are correctly recognized in the slug

Fixes Yoast/YoastSEO.js#2121

Transferred from Yoast/YoastSEO.js#2129

@manuelaugustin manuelaugustin changed the title Fix keyphrase in slug researcher for compound keyphrases with hyphens LIN-623 Fix keyphrase in slug researcher for compound keyphrases with hyphens Sep 24, 2020
@agnieszkaszuba
Copy link
Contributor

I'm closing this PR because we have a new PR to cover some of the changes from this PR, as well as an issue to cover the remaining changes.

@agnieszkaszuba agnieszkaszuba deleted the split-compounds-for-keyphrase-in-slug-research branch September 10, 2021 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyword matching for Slug in URL permalink fails when there is a hyphen in the keyword
3 participants