Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

All the links with target _blank in the assessments results should inform users the link opens in a new tab #2131

Open
afercia opened this issue Feb 6, 2019 · 0 comments

Comments

@afercia
Copy link
Contributor

afercia commented Feb 6, 2019

In the assessment results, most (all?) of the results contain links:

screenshot 2019-02-04 at 10 34 51

These links use target="_blank" but don't use any text to inform users the link is going to open in new browser's tab. Additionally, links that don't point to yoast.com (if any) should use rel="noopener".

Re: the first part, we have PHP utilities (in Yoast SEO) and JS utilities (in yoast-components) to generate the visually hidden text (Opens in a new browser tab). Suggested: add a function to Shortlinker to generate the text and closing </a> tag and replace the hardcoded </a> across the codebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants