Tests: use PSR-4 #360
Merged
Tests: use PSR-4 #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to comply with the YoastCS naming conventions. These weren't being flagged so far as the tests are using a non-conventional directory layout.
* Ensure all test class names reflect the name of the class under test. * Ensure all test class file names match the name of the test class. * Change the Composer `autoload-dev` directive to use PSR-4 autoloading. * Update the `phpunit.xml.dist` file to match. * Update the `.phpcs.xml.dist` file to match.
jrfnl
added
yoast cs/qa
changelog: non-user-facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Tests: move mock acf class to Doubles directory
Tests: move unit tests to tests\Unit subdirectory
Tests: rename some mock classes
... to comply with the YoastCS naming conventions.
These weren't being flagged so far as the tests are using a non-conventional directory layout.
Tests: use PSR-4
autoload-devdirective to use PSR-4 autoloading.phpunit.xml.distfile to match..phpcs.xml.distfile to match.Test instructions
This PR can be tested by following these steps: