-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a sniff to make sure filter_input
is not used with only the default settings
#70
Comments
This can be added to the sniff introduced in #74 |
👋🏻 We also need to make sure to forbid the string filter which has been deprecated in PHP 8.1. |
@increddibelly, @jrfnl had a discussion about the filter functions and came up with a list of filter that we want to forbid:
|
And let's extend the filter requirements to ALL functions in the Filter extension: https://www.php.net/manual/en/book.filter.php |
Also loosely related #34 |
Related upstream issues:
Any sniff we would create here would be a candidate to be pulled upstream at a later point in time. |
Been doing some digging into the filter extension and discovering more and more WTFs. The sniff I'm currently writing will comprehensively check for all of them. You may not like what you see when we run the sniff over the various code bases.... |
As the default is RAW INPUT, this does not add anything.
The text was updated successfully, but these errors were encountered: