From 2d187bda742ded9269c51135a64c8c734c422b13 Mon Sep 17 00:00:00 2001 From: Gustavo Valverde Date: Thu, 26 Dec 2024 15:09:37 -0400 Subject: [PATCH] fix(workflows): streamline environment input handling in CI configurations - Removed the required environment input from `sub-ci-integration-tests-gcp.yml`. - Updated comments in `sub-deploy-integration-tests-gcp.yml` to clarify the strategy for creating images in dev and prod environments based on the main branch. --- .github/workflows/sub-ci-integration-tests-gcp.yml | 3 --- .github/workflows/sub-deploy-integration-tests-gcp.yml | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/sub-ci-integration-tests-gcp.yml b/.github/workflows/sub-ci-integration-tests-gcp.yml index 65d751ed7eb..d4e4bd506d4 100644 --- a/.github/workflows/sub-ci-integration-tests-gcp.yml +++ b/.github/workflows/sub-ci-integration-tests-gcp.yml @@ -8,9 +8,6 @@ name: Integration Tests on GCP on: workflow_call: inputs: - environment: - required: true - type: string network: default: "Mainnet" type: string diff --git a/.github/workflows/sub-deploy-integration-tests-gcp.yml b/.github/workflows/sub-deploy-integration-tests-gcp.yml index 7b4cbb4449b..9596aed6c19 100644 --- a/.github/workflows/sub-deploy-integration-tests-gcp.yml +++ b/.github/workflows/sub-deploy-integration-tests-gcp.yml @@ -388,6 +388,8 @@ jobs: permissions: contents: 'read' id-token: 'write' + # We want to create images for both dev and prod environments, + # but for prod we only want to create images from the main branch strategy: matrix: environment: ${{ github.ref_name == 'main' && fromJSON('["dev", "prod"]') || fromJSON('["dev"]') }}