Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build process #2

Open
omershlo opened this issue Jul 20, 2019 · 4 comments
Open

Improve build process #2

omershlo opened this issue Jul 20, 2019 · 4 comments
Labels
binding relates to c binding help wanted Extra attention is needed

Comments

@omershlo
Copy link
Contributor

Currently the build.rs file will re-install pari library each time we cargo build. This is taking very long time and unnecessary if pari is already installed.
Find a way to change build.rs to check if pari is already installed and if it does - skip installation.

@omershlo omershlo added binding relates to c binding help wanted Extra attention is needed labels Jul 20, 2019
@knarz
Copy link
Contributor

knarz commented Jul 22, 2019

The build process could use some overhauling in general. For Windows/macOS the library should just be statically linked and not leave any artifacts on the system.

@omershlo
Copy link
Contributor Author

I agree. can you help ?

@amanusk
Copy link
Contributor

amanusk commented Jul 24, 2019

Suggestion:
PARI is a well maintained library, and has extensive installation documentation ftp://pari.math.u-bordeaux.fr/pub/pari/manuals/2.7.6/INSTALL.pdf as well as packages in at least some Linux distributions:
https://packages.ubuntu.com/bionic/libpari-dev

Why not add interactions for installation, then remove the entire make process from build.rs?

I was able to compile and pass all tests without rebuilding the local library (which of course takes a lot less time)

Alternatively, add it as a git submodule, with installation instructions

@omershlo
Copy link
Contributor Author

I saw this method in other libraries.
One motivation is that in my method you don't need to update version and make adjustments for each new Pari versions.
Another possible advantage is that we can make changes to Pari

@omershlo omershlo changed the title Install Pari only once Improve build process Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding relates to c binding help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants