Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure mask_generation sampling avoids modulo bias #17

Open
omershlo opened this issue Oct 11, 2020 · 0 comments
Open

make sure mask_generation sampling avoids modulo bias #17

omershlo opened this issue Oct 11, 2020 · 0 comments
Labels
help wanted Extra attention is needed security

Comments

@omershlo
Copy link
Contributor

let msklen = out_length / DIGEST_SIZE + 1; // adding one sha256 is more efficient then rejection sampling (see A.4 (e) in the paper)

(thanks to JP an team who raised this concern)

@omershlo omershlo added help wanted Extra attention is needed security labels Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed security
Projects
None yet
Development

No branches or pull requests

1 participant