Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the Price with QR Code #1600

Open
Steampowered-hippo opened this issue Aug 14, 2023 · 3 comments · May be fixed by #1602
Open

Display the Price with QR Code #1600

Steampowered-hippo opened this issue Aug 14, 2023 · 3 comments · May be fixed by #1602
Labels
Feature request New feature request QR Codes

Comments

@Steampowered-hippo
Copy link

Describe the feature

When the QR-Code - page of a lightning invoice is shown, the invoice's value should also be displayed in Sats and Fiat. Especially when paying with NFC, you have now no chance to check the value of the invoice.

@Steampowered-hippo Steampowered-hippo added the Feature request New feature request label Aug 14, 2023
@myxmaster
Copy link
Contributor

I like this idea. But you should be aware that it is easy for scammers to present a QR code to you with a fake amount. So you still need to trust the person that is presenting the QR to you.

@Steampowered-hippo
Copy link
Author

Yes, I understand the problem. But when you pay via NFC Card you always will have this problem.
I experienced the following: In a restaurant, that accepts BTC via LN, the waiter types the amount usual without the decimal in his (Fiat) cash system (e.g.: he types "450 for 4.50 Fiat). So he wanted me to pay 450 instead of 4.50. When I payed with my own Lightning Wallet (Zeus), the amount was displayed on my device, so I discovered the error. With NFC, I would have had no chance. (aside from a limit).

Another idea is, to configure a PIN with the card, that I have to type in with the payment. Similar to a payment with Credit card.

@myxmaster
Copy link
Contributor

You are right, even if you can trust the seller, mistakes can happen and with this improvement it would be possible to avoid it. I'll look into it and make a PR.

@myxmaster myxmaster linked a pull request Aug 17, 2023 that will close this issue
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request New feature request QR Codes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants