Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary screen rendering when picking a contact to send to #2421

Closed
myxmaster opened this issue Sep 18, 2024 · 2 comments · Fixed by #2422
Closed

Unnecessary screen rendering when picking a contact to send to #2421

myxmaster opened this issue Sep 18, 2024 · 2 comments · Fixed by #2422
Assignees
@shubhamkmr04
Labels
Contacts Enhancement
Milestone
v0.9.2

Comments

@myxmaster
Copy link
Contributor

Describe your enhancement idea

Steps to reproduce:
Swipeable row -> Send -> Contact icon -> pick a contact (not one with multiple addresses)
--> Zeus will shortly display the contact detail view, then automatically proceed to Send, and eventually LnurlPay screen (or whatever makes sense, decided by handleAnything). The unnecessary contact detail view is visible even on the phone, where performance is much better than on an emulator.

In case a contact has multiple addresses, the contact detail view should of course be displayed so the user can pick where to send (ln address, BOLT 12 address, pubkey, whatever), but if there are no multiple addresses, this can be skipped which will lead to noticable better performance.
@myxmaster myxmaster mentioned this issue Sep 18, 2024
Merged
30 tasks
@shubhamkmr04
Copy link
Contributor

I can't reproduce this issue

@myxmaster
Copy link
Contributor Author

I am seeing this on an Android phone and also emulator.

Please try hitting the back button, after you picked a contact with e.g. an LN address and ended up on the LnurlPay screen. After you hit back, you will see the contact detail view, which proves, that it was rendered. Maybe it is too fast on your test device to see it.

@kaloudis kaloudis added this to the v0.9.2 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhamkmr04 shubhamkmr04

Labels
Contacts Enhancement
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging a pull request may close this issue.

Skip navigating from SendScreen to ContactDetails in case contact has only 1 address myxmaster/zeus
3 participants
@kaloudis @shubhamkmr04 @myxmaster