Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS/Utils nameHash appends '.eth' to input name, breaking dnssec domain names #10

Open
bobwith2bees opened this issue Mar 20, 2024 · 0 comments

Comments

@bobwith2bees
Copy link

bobwith2bees commented Mar 20, 2024

This is just an observation that this will probably cause trouble for the additional domains ens now resolved.

nameHash function

if (!inputName.contains('.eth')) {
inputName = '$inputName.eth';
}

test/ens_dart_test.dart for coverage (note this still fails, but I suspect that is due to an older resolver contract integration.)

    test('.getname on non.eth domain', () async {
      // https://app.ens.domains/gregskril.com
      // OffchainDNSResolver: 0xF142B308cF687d4358410a4cB885513b30A42025
      final emptyName = await ens.withName('gregskril.com').getAddress();
      print(emptyName);
      expect(emptyName, EthereumAddress.fromHex('0x179A862703a4adfb29896552DF9e307980D19285'));
    });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant