Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for txns before proposing an empty block with an AggQC #1320

Closed
DrZoltanFazekas opened this issue Aug 19, 2024 · 0 comments · May be fixed by #1620
Closed

wait for txns before proposing an empty block with an AggQC #1320

DrZoltanFazekas opened this issue Aug 19, 2024 · 0 comments · May be fixed by #1620
Assignees
@86667

Comments

@DrZoltanFazekas
Copy link
Contributor

In case of blocks proposed from Votes (i.e. they have a QC attached), if there are no transactions in the mempool that we can include in the block, we wait before we propose an empty block: https://github.com/Zilliqa/zq2/blob/main/zilliqa/src/consensus.rs#L943-L961

In case of blocks proposed from NewView messages (i.e. they have an AggQC attached), this behaviour hasn't been implemented (yet).
@DrZoltanFazekas DrZoltanFazekas changed the title Wait for txns before proposing an empty block with an AggQC wait for txns before proposing an empty block with an AggQC Aug 19, 2024
@86667 86667 self-assigned this Oct 9, 2024
@86667 86667 added phase2 proto-mainnet and removed phase2 proto-mainnet labels Oct 9, 2024
@86667 86667 linked a pull request Oct 11, 2024 that will close this issue
Standardise proposal creation process #1620
Open
@86667 86667 mentioned this issue Oct 11, 2024
Open
@86667 86667 closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@86667 86667

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardise proposal creation process Zilliqa/zq2
2 participants
@86667 @DrZoltanFazekas