Fix serialization of byte arrays in SD-JWT #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
context, please! what is going on and why? |
nodh
force-pushed
the
fix/sdjwt-serialization
branch
from
7c41ed1
to
541cddf
Compare
nodh
force-pushed
the
fix/sdjwt-serialization
branch
from
ab01690
to
cb70663
Compare
JesusMcCloud
requested changes
Sep 26, 2024
Comment on lines
66
to
68
| familyName?.let { optionalClaim(claimNames, "family_name", it) }, | ||
| userInfo.userInfo.birthDate?.let { optionalClaim(claimNames, "date_of_birth", it) }, | ||
| userInfo.userInfo.picture?.let { optionalClaim(claimNames, CLAIM_PORTRAIT, it.decodeToByteArray(Base64())) }, |
There was a problem hiding this comment.
These could also be constants
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/data/SelectiveDisclosureItem.kt
Show resolved
Hide resolved
| @@ -160,6 +144,18 @@ class AgentSdJwtTest : FreeSpec({ | |||
|
|
|||
| }) | |||
|
|
|||
| private fun buildPresDef(vararg attributeName: String) = PresentationDefinition( | |||
There was a problem hiding this comment.
I know it's odd coming from me, but still: I'd spell out the function name
JesusMcCloud
approved these changes
Sep 27, 2024
nodh
force-pushed
the
fix/sdjwt-serialization
branch
from
5f66297
to
547288a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it works, just leave the deserialization up to implementers.