Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests failing in helios-ethereum #415

Closed
0xRampey opened this issue Oct 30, 2024 · 4 comments · Fixed by #417
Closed

fix: tests failing in helios-ethereum #415

0xRampey opened this issue Oct 30, 2024 · 4 comments · Fixed by #417

Comments

@0xRampey
Copy link
Contributor

Unit tests for ConsensusClient expect more generic arguments
@mw2000
Copy link
Contributor

mw2000 commented Oct 30, 2024

I see a few more compiler errors in the benches package while using rust-analyzer. Putting up a PR to fix those + tests

@0xRampey
Copy link
Contributor Author

0xRampey commented Oct 30, 2024 •
edited
Loading

I have an (almost) ready PR for the tests.
Perhaps you can open another issue for the 'benches' crate errors?

@mw2000
Copy link
Contributor

mw2000 commented Oct 30, 2024

My bad! I didn't realize you were actively working on the issue. I had put up the PR here #416, but happy to reshape that into being focused on benches crate errors.

@0xRampey
Copy link
Contributor Author

0xRampey commented Oct 30, 2024 •
edited
Loading

No worries. I should've marked the issue before starting work on it. Thanks for understanding!

@0xRampey 0xRampey mentioned this issue Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: tests in helios-ethereum 0xRampey/helios
2 participants
@0xRampey @mw2000