Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JoltPolynomial / JoltCommitments logic #382

Closed
sragss opened this issue Jun 10, 2024 · 0 comments
Closed

Improve JoltPolynomial / JoltCommitments logic #382

sragss opened this issue Jun 10, 2024 · 0 comments

Comments

@sragss
Copy link
Collaborator

sragss commented Jun 10, 2024

Flow is currently:

vm/mod.rs
fn prove(...) {
    let instruction_polys = InstructionLookupsProof::polynomialize();
    let memory_polys = ReadWriteMemory::new();
    let bytecode_polys = BytecodePolynomials::new();
    let rangecheck_polys = RangecheckPolynomials::new();
    let (witness_segments, r1cs_commitments) = Self::r1cs_setup();
    let jolt_commitments = jolt_polynomials.commit();

    jolt_commitments.r1cs = Some(r1cs_commitments);
}

Instead let's return the R1CS specific stuff from r1cs_setup(), use it to construct JoltPolynomials then commit them all together. Additionally R1CSInputs is a duplicate of JoltPolynomials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants