ItemRequested includes pickup lib now

[eby]

This code presumes that the pickup library isn't passed but looking at code it currently is. Right now it defaults to just MeL as the pickup library. Once the item ships it updates the pickup to the actual library. Some patrons find this confusing. If the shipped message doesn't come in then we also don't get the pickup change.

iNCIPit/iNCIPit.cgi

Lines 1727 to 1729 in 929dcd6

	# NOTE: When User Agency, we don't know the pickup location until ItemShipped time
	# TODO: When Item Agency and using holds, set this to requested copy's circ lib?
	$ahr->pickup_lib($conf->{hold}->{init_pickup_lib});

Example message with user removed:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE NCIPMessage PUBLIC "-//NISO//NCIP DTD Version 1.0//EN" "http://www.niso.org/ncip/v1_0/imp1/dtd/ncip_v1_0.dtd">
<NCIPMessage version="http://www.niso.org/ncip/v1_0/imp1/dtd/ncip_v1_0.dtd">
    <ItemRequested>
        <InitiationHeader>
            <FromAgencyId>
                <UniqueAgencyId>
                    <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=UniqueAgencyId</Scheme>
                    <Value datatype="string">zv381</Value>
                </UniqueAgencyId>
            </FromAgencyId>
            <ToAgencyId>
                <UniqueAgencyId>
                    <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=UniqueAgencyId</Scheme>
                    <Value datatype="string">zv512</Value>
                </UniqueAgencyId>
            </ToAgencyId>
        </InitiationHeader>
        <UniqueUserId>
            <UniqueAgencyId>
                <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=UniqueAgencyId</Scheme>
                <Value datatype="string">zv512</Value>
            </UniqueAgencyId>
            <UserIdentifierValue datatype="string">xxxxxx</UserIdentifierValue>
        </UniqueUserId>
        <UniqueItemId>
            <UniqueAgencyId>
                <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=UniqueAgencyId</Scheme>
                <Value datatype="string">zv381</Value>
            </UniqueAgencyId>
            <ItemIdentifierValue datatype="string">i18009283</ItemIdentifierValue>
        </UniqueItemId>
        <RequestType>
            <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=RequestType</Scheme>
            <Value datatype="string">hold</Value>
        </RequestType>
        <RequestScopeType>
            <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=RequestScopeType</Scheme>
            <Value datatype="string">item</Value>
        </RequestScopeType>
        <ShippingInformation>
            <ShippingNote datatype="string">zv512 AADL Malletts Creek Br</ShippingNote>
            <PhysicalAddress>
                <UnstructuredAddress>
                    <UnstructuredAddressType>
                        <Scheme datatype="string">http://www.niso.org/ncip/v1_0/imp1/schemes/unstructuredaddresstype/</Scheme>
                        <Value datatype="string">Pickup Location</Value>
                    </UnstructuredAddressType>
                    <UnstructuredAddressData datatype="string">AADL-Malletts Creek Branch</UnstructuredAddressData>
                </UnstructuredAddress>
                <PhysicalAddressType>
                    <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=PhysicalAddressType</Scheme>
                    <Value datatype="string">Pickup Location</Value>
                </PhysicalAddressType>
            </PhysicalAddress>
        </ShippingInformation>
        <DateOfUserRequest datatype="dateTime">2021-04-07T21:51:56Z</DateOfUserRequest>
        <ItemOptionalFields>
            <BibliographicDescription>
                <Author datatype="string">Wilson, Cintra.</Author>
                <Title datatype="string">A massive swelling : celebrity re-examined as a grotesque, crippling disease, and other cultural revolutions / Cintra Wilson.</Title>
                    <MediumType>
                    <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=MediumType</Scheme>
                    <Value datatype="string">MeL Book</Value>
                </MediumType>
            </BibliographicDescription>
            <ItemDescription>
                <CallNumber datatype="string">306.484 W</CallNumber>
            </ItemDescription>
        </ItemOptionalFields>
        <UserOptionalFields>
            <VisibleUserId>
                <VisibleUserIdentifierType>
                    <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=VisibleUserIdentifierType</Scheme>
                    <Value datatype="string">Barcode</Value>
                </VisibleUserIdentifierType>
                <VisibleUserIdentifier datatype="string">xxxxxxxxx</VisibleUserIdentifier>
            </VisibleUserId>
            <UserPrivilege>
                <UniqueAgencyId>
                    <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=UniqueAgencyId</Scheme>
                    <Value datatype="string">zv512</Value>
                </UniqueAgencyId>
                <AgencyUserPrivilegeType>
                    <Scheme datatype="string">http://72.52.134.169:6601/IRCIRCD?target=get_scheme_values&amp;scheme=AgencyUserPrivilegeType</Scheme>
                    <Value datatype="string">MeL No AV Adult</Value>
                </AgencyUserPrivilegeType>
            </UserPrivilege>
        </UserOptionalFields>
    </ItemRequested>
</NCIPMessage>