Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests/specs #88

Open
eclubb opened this issue Jan 22, 2015 · 5 comments
Open

Add tests/specs #88

eclubb opened this issue Jan 22, 2015 · 5 comments

Comments

@eclubb
Copy link

eclubb commented Jan 22, 2015

I'm getting ready to write some tests for git-up. Any objections to RSpec?

@aanand
Copy link
Owner

aanand commented Jan 23, 2015

Not strong ones, but this isn't a very maintained project in the first place, and is less relevant now that Git 2.0 has better push behaviour.

@eclubb
Copy link
Author

eclubb commented Jan 26, 2015

I'm curious. How does the new push behavior in Git 2.0 make the smart pulling that git-up provides less relevant?

@aanand
Copy link
Owner

aanand commented Jan 27, 2015

Prior to Git 2.0, git push tried to push everything. The discrepancy between that and git pull (which only updates the current branch) meant that git push would frequently complain at you that you were trying to push an old commit to some other branch you didn't care about.

Now that git push only pushes the current branch by default, that's less of an issue. There are other benefits to git up of course - keeping several branches continuously up to date, getting an overview of their status etc - but I haven't personally been on a team with a workflow that makes that particularly valuable for some time now. As a result, I've been using git up less and not really maintaining it.

I'd still like to find the time for a grand rewrite, for several reasons:

  • I hate distributing command-line tools via language-specific packaging frameworks like RubyGems or PyPi - it's such a barrier to installation
  • There are some arbitrarily Ruby-specific features that I'd rather replace with a more generic hook system (see Hooks #66)
  • I don't really like Ruby any more

...but these days I have so little time.

@vdemario
Copy link

Adding my two cents as a user.

I've been a regular user of git up for months now, maybe more than a year. It has become one of those commands that get written by muscle memory, I don't even think about it anymore.

For me, those "other benefits" are actually the main reason I like to use it. I can understand that in the general case that is not particularly valuable. That said, it feels like the grand rewrite will probably never happen, which is not a problem, so I only ask the maintainers that those behaviors not be lost if an attempt to do the rewrite stumbles.

In summary, git up is fine as it is, please don't break it. I'm always afraid of the grand redesign in the sky. :P

@msiemens
Copy link

Concerning tests: I have an integration test suite in my Python port. If git-up gets a test suite, I would try to keep my one in sync with it so both implementations stay compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants