-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Thoughts #3
Comments
Thanks for this @Snugug!
Fair point. I had some explainer text over on this thread in WICG but have not brought it back over to this yet. I’ll update accordingly.
That’s totally fair. Are you thinking something that is somewhat time-based like "hourly" or totally vague like "often" and "very often"? I also wonder if there should be a "user configurable" option with an initial preference.
I agree to some degree, but also think it becomes super redundant to create multiple bespoke widget definitions for each independent platform. My hope is to create an upgrade path from templated widget to rich widget (should the developer so desire) but also platform enable customization through the inherent extensibility of the Manifest. That way you have a widget that progressively enhances into whatever container. FWIW, I have an analogous idea of providing a
Totally fair point. I was planning on
That was my typo. I originally had it as |
The "feeds" concept is in the sample manifest file (lines 92-103). |
@Snugug I just made a ton of additions to the proposal to (hopefully) clarify things a bit more. Would love your thoughts. |
Thanks for the ping! Here are my thoughts on this new read.
Overall, I generally like this new direction. I think I'd really like to see an example of a rich widget (how do MPA transitions work, or does it need to be an SPA? How can I reuse the same rich widget definition multiple times?) and there are still a few things not connecting for me w/r/t data and actions, but the rest of the lifecycle stuff, and the intent, is all much clearer now. |
Thanks for sharing this w/me @aarongustafson! Here are my initial thoughts! I think the real tl;dr takeaway of these is that I think there should be a separation between defining widgets and configuring widgets, and given that separation.
Basic definition thoughts
tag
instead ofid
given thattag
is defined asclient.id
?tag
isn't clear to me on first glance as the ID for the widget.widget
(as in sample) ortemplate
(as in Templated Widgets) to define what widget template to use?Overall thoughts
update
feels like maybe it should be something like keywords for frequency instead of seconds? I'm a bit torn here, but saying I want this to update every 900 seconds and then having the definition of update be "thanks for your request, we'll get to it when we see fit" feels worse to me than more vague keywords.type
feels like it is inherently tied to the widget type, or more likely a bit of configuration for a piece of widget data. See next.WidgetDefinition
- Focused on creating a custom widget. Requires an identifier (maybe following CSS's lead with some defined prefix, likewidget-{{foo}}
like data attributes require a leadingdata-
),url
as currently defined, and optionaldata
, which would include a list of required and optional parameters (with some way to do validation, probably in the SW) and thetype
expected for each.backgrounds
andicons
are optionally be always optional. This would allow someone to define a custom widget as follows:Widgets
- Focused on configuring a widget, so would requirename
,id
,template
, and optionaldata
,update
, andactions
. Things likeicons
andbackgrounds
should live underdata
. The Adaptive Card example could then be re-written as:The text was updated successfully, but these errors were encountered: