Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentParser superseding environment variables for options? #449

Closed
rbonestell opened this issue Nov 18, 2024 · 1 comment · Fixed by #451
Closed

ArgumentParser superseding environment variables for options? #449

rbonestell opened this issue Nov 18, 2024 · 1 comment · Fixed by #451

Comments

@rbonestell
Copy link

Hery @aaronshaf !

It seems that as a result of PR #447 that dynamodb-admin is no longer utilizing the environment variables to initialize the service.

My team uses your docker image for our local development stack, providing the following env vars:

environment:
  - DYNAMO_ENDPOINT=http://localstack:4566
  - AWS_REGION=us-west-2
  - AWS_ACCESS_KEY_ID=localstack
  - AWS_SECRET_ACCESS_KEY=localstack

Now, when dynamodb-admin v5.0.0 loads in docker, it prints the following:

2024-11-18 11:14:33   database endpoint:        http://localhost:8000
2024-11-18 11:14:33   region:           us-west-2
2024-11-18 11:14:33   accessKey:                localstack
2024-11-18 11:14:33 
2024-11-18 11:14:33   dynamodb-admin listening on http://:::8001 (alternatively http://0.0.0.0:8001)

This is likely due to the release v5.0.0 introducing ArgumentParser in bin/dynamodb-admin.ts and the default values may be overriding env vars?

@rchl
Copy link
Collaborator

rchl commented Nov 18, 2024

ArgumentParser was there before too but I'll look at this regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants