Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: residual not stored in member variable of (pose) sensor class #11

Closed
mascheiber opened this issue Aug 28, 2023 · 1 comment
Closed

Comments

@mascheiber
Copy link
Member

@antithing recently pointed out that within the pose sensor class, the calculated residual is not stored within the member variable of the inherited UpdateSensorAbsClass:

Eigen::MatrixXd res(res_p.rows() + res_r.rows(), 1);
res << res_p, res_r;

Thus an access from outside the update function to the last residual is not possible.

This issue might also effect other sensor classes.

The issue was originally posted by @mascheiber in #9 (comment)

Concerning the residual printing, I just saw that this is a bug within the pose sensor class, where the value is only stored locally but not written to the residual_ member variable.

Thus thank you for pointing this out, will be providing a fix soon.

For now you could add the printing the in the pose_sensor_class.h, line 204:

Eigen::MatrixXd res(res_p.rows() + res_r.rows(), 1);
res << res_p, res_r;

@Chris-Bee
Copy link
Member

Fixed by @mascheiber in 365396b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants