Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive domain separator #20

Open
LHerskind opened this issue Nov 2, 2021 · 0 comments
Open

Adaptive domain separator #20

LHerskind opened this issue Nov 2, 2021 · 0 comments
Assignees

Comments

@LHerskind
Copy link

The staked token implementation writes DOMAIN_SEPARATOR to storage in initialize. It will therefore not be able to handle a hard fork post-deployment, as the chainID is not updated and a valid signature for one chain could be replayed on the other.

The issue can be handled by using a dynamic domain separator which is generated on demand instead of reading from storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant