Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify signERC20Approval for non-standard permit tokens #500

Open
defispartan opened this issue Jan 26, 2023 · 1 comment
Open

Modify signERC20Approval for non-standard permit tokens #500

defispartan opened this issue Jan 26, 2023 · 1 comment

Comments

@defispartan
Copy link
Collaborator

signERC20Approval is used to generate the signature payload for methods which support permit. A lot of tokens have permit features disabled because they do not implement the EIP-2612 interface.

After reviewing all tokens, there are 0 which are currently disabled but could be enabled with a small change to the signature request.

OP - Optimism
AAVE - Optimism
DAI - Optimism
DAI - Arbitrum
EURS - Arbitrum
FRAX - Avalanche
USDC - Avalanche
USDC - Polygon
USDC - Mainnet

Despite the EIP-2612 specs saying that the nonce value should be current, all of these token check that the nonce + 1, so nonce should be incremented in signERC20Approval for these tokens as well.

@danielnordh
Copy link

danielnordh commented Jun 6, 2024

Would love for USDC on Polygon to be enabled. 🤞
(and Base)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants