Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DLL name #117

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Change DLL name #117

merged 3 commits into from
Sep 18, 2023

Conversation

abedra
Copy link
Owner

@abedra abedra commented Sep 6, 2023

References #116

@SpaceIm
Copy link

SpaceIm commented Sep 6, 2023 •
edited
Loading

It should be:

if(WIN32)
    set_target_properties(vault PROPERTIES RUNTIME_OUTPUT_NAME "VaultClient")
endif()

@abedra
Copy link
Owner Author

abedra commented Sep 8, 2023

Thanks! I've updated. Let me know if this works correctly for you and i'll merge it up and cut a release

@SpaceIm
Copy link

SpaceIm commented Sep 17, 2023 •
edited
Loading

It must be moved after add_library()

@abedra abedra merged commit 0c9b4a8 into master Sep 18, 2023
6 checks passed
@abedra abedra deleted the dll branch September 18, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abedra @SpaceIm