Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progression beyond "Grade A unlocked" #47

Closed
CaptainSlow72 opened this issue May 27, 2022 · 11 comments · Fixed by #52
Closed

Progression beyond "Grade A unlocked" #47

CaptainSlow72 opened this issue May 27, 2022 · 11 comments · Fixed by #52
Assignees
Labels
enhancement New feature or request

Comments

@CaptainSlow72
Copy link

Description:
There seems to be a bug, at least at karting series.
When you record a result in grade A (even it is 1st place) the "A" in the path is not replaced by a checkmark symbol.
Maybe also same behaviour for other series, not tested yet.
Grade A for karting series was unlocked without driving any karting series, but gaining enough XP from driving other series.

@CaptainSlow72 CaptainSlow72 added the bug Something isn't working label May 27, 2022
@abesto
Copy link
Owner

abesto commented May 27, 2022

Hi, thanks for the report, @CaptainSlow72! Hm, interesting. For what it's worth, this is working as intended: "completing" a grade currently means moving up to the next grade. Since there's no grade after A, you just ... kind of ... stay there, and stop gaining XP.

So on one hand this is confusing as it's inconsistent with the other grades; and on the other, maybe there should be some progression inside grade A towards "you've now totally mastered this discipline". @rsr427 what do you think?

@abesto abesto added enhancement New feature or request and removed bug Something isn't working labels May 27, 2022
@CaptainSlow72
Copy link
Author

Hi, just replace the "A" by a checkmark symbol after recorded first time, so one can distinguish if this final race of a series has been unlocked (grade "A" is now available to be recorded) or was recorded at least once ("mastered", indicated by the checkmark symbol).
Just keep it simple and consistent.

@abesto
Copy link
Owner

abesto commented May 27, 2022

To keep things consistent (and to maintain a sense of progression), I'd expect the XP needed to go from "grade A unlocked" to "grade A mastered" to be a natural progression on the XP curve so far. The nudge for @rsr427 is mostly because he designed the progression system so far, and I'd be most comfortable with him sorting good-feeling numbers here as well.

We could also take it a step further btw: some kind of "prestige" levels (as seen in Diablo 3 for example) where each new level after unlocking grade A brings ... more challenges? Not sure what that'd look like, maybe an AI level bump I guess. Or at least an infinite number of prestige levels to unlock with appropriately scaled XP costs.

@rsr427
Copy link
Collaborator

rsr427 commented May 28, 2022

First, kudos to you @CaptainSlow72 for spending time in the karts. I couldn't do it... I don't think it's unrealistic to be considered a grade A Karter without having ever raced a kart. If I got licenced and qualified for a GT4 race, I'm sorry, but you better consider a grade A Karter.

It is a very good question as to what to do when you reach the top. I'll admit I should have one more level to complete when you reach the top cars. I have to confer with @abesto , but maybe at that point, the game unlocks a suggested season with a certain number of races at a random selection of tracks. The goal is to win the championship at the top of that discipline. What say you all?

@CaptainSlow72
Copy link
Author

The more to do as a player in the career the better.
As you (rsr) already know from the Reiza forum, I would like to have a much more expanded career with many many many more series or challenges.
But for a starter we just need an indication if a grade was unlocked or mastered. In its current state, you cannot see if just unlocked or already mastered.

By the way, great app, I love it and it keeps me playing AMS 2.

@abesto abesto changed the title Karting series cannot be completed Progression beyond "Grade A unlocked" May 30, 2022
@abesto
Copy link
Owner

abesto commented Jun 3, 2022

After giving this a bit of thought, I'd propose approaching this in three phases:

  1. @rsr427 figures out XP numbers for each discipline that make sense for going from "Grade A is unlocked" to "Grade A is mastered". I'll plug it into the app, and update the special-case logic for handling Grade A accordingly. This fixes the immediate confusion, and adds gameplay value for Grade A.
  2. Let's figure out a closed formula for "how much XP do you need to go from Grade X to Grade X+1 in discipline D". This will probably need to take a hard-coded parameter for how "hard" a discipline is, or maybe something more complex to better describe a specific XP curve. This allows us to remove the hard-coded XP breakpoints, and makes it much cheaper to add / remove disciplines and grades. Once that's done, I'd close this issue as properly fixed.
  3. Let's break out a separate discussion about next steps for enriching gameplay. Maybe that's more challenges, maybe it's end-game only, maybe a completely different format for the complete progression (ideas for a proper career mode with teams, championships, and so on have been thrown around).

Note that for 1. and 2. changes will be applied retroactively whenever a new version rolls out and players reload the app - this is as designed. There may potentially be some confusion ("hey, didn't I already unlock X?"), but it feels like the obviously better choice than "you have to completely restart from scratch" (and I don't have the bandwidth to implement user-controlled version switching). We may want to start thinking about a changelog popup.

@abesto abesto self-assigned this Jun 3, 2022
@rsr427
Copy link
Collaborator

rsr427 commented Jun 3, 2022

@abesto I should share with you the sketchup for my next idea. Its a lot more procedural based as far as car class and xp and unlocks. There are more variables like License Points and Rep Points, but stuff related to cars is different. There are 15 total grades, with F1 at the top and club at the bottom. Open wheel C might be on Level 4, whereas Club grade C would be level 13. The progression is based more on the level and not an XP table that is specific to a car.

Uses the came car class labels at this time and track matrix. Cars still need to be stuck into a level, but that's not that tough. The progression and reward tables are already created.

@abesto
Copy link
Owner

abesto commented Jun 6, 2022

Sounds exciting! If you're comfortable with it, I'd love to have that discussion in the open: makes it easy for others (current and future readers) to understand what works how why. I created a GitHub discussion for it, feel free to start dropping stuff in there when convenient: #50

Meanwhile, referencing #42 (comment): I'm starting work on addressing this issue by adding the bare minimum needed to add some progression in Grade A; that's "gain X more XP", same as the previous grades. ("or N podiums" sounds fun, and I want to separate that work out).

For just the XP-based mastery:

  • The XP breakpoints make sense to me. For example, the progression for Club then becomes 0.15 1.3 4 10. That feels about right to me.
    • Side-note to anyone following along: the XP displayed on the UI has a * 100 multiplier to be more human-friendly. Sooner or later we'll have a misunderstanding and bug because of this, so: Un-confuse XP representation #51
  • We have an input "grade multiplier", which is already defined as 1.0 for Grade A in all disciplines. I think that also makes sense, but I'm calling it out in case you think it needs tweaking.

@abesto
Copy link
Owner

abesto commented Jun 7, 2022

Hm, 12XP for the Special discipline seems weird. It takes 12.5 to go from Grade B to Grade A, feels like it should take more than that to finish Grade A?

@rsr427
Copy link
Collaborator

rsr427 commented Jun 8, 2022

Hm, 12XP for the Special discipline seems weird. It takes 12.5 to go from Grade B to Grade A, feels like it should take more than that to finish Grade A?

I used the debugger to see how much XP is earned in each discipline and it seems 3 is about the max in Special. So 5 good races will see you hit that milestone.

https://ibb.co/jGG7cZB

@abesto abesto closed this as completed in #52 Jun 8, 2022
@abesto
Copy link
Owner

abesto commented Jun 12, 2022

To make sure stuff here isn't forgotten, I've

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants