Add async version of IRestChannel.Status
#1264
Conversation
|
This isn't actually adding anything - rather it's making something that exists public. |
Thanks for creating the PR, we will look into this 👍 |
|
@sacOO7 I've tried to add a test following the pattern in the repo - can you let me know if make sense please? |
| } | ||
|
|
||
| [Fact] | ||
| [Trait("spec", "XXX")] |
There was a problem hiding this comment.
Not sure what value I should have here
There was a problem hiding this comment.
Can you check if we have existing tests for channel.Status and add this test side by side?
There was a problem hiding this comment.
it's related to ably protocol spec id. https://sdk.ably.com/builds/ably/specification/main/features/#RSL8
|
@fdmarc we already have a test for |
|
@sacOO7 what do we need to do to move forward with this? thanks |
|
@fdmarc I am busy with other things, it will be great if you can search for the test marked as a trait |
|
@fdmarc I have created a new PR where we will move/fix the tests |
|
@fdmarc fix is available as a part of |
Fixes #1263