Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties should not be public-mutable on the Realtime Connection class #452

Open
QuintinWillison opened this issue Nov 29, 2022 · 1 comment
Open

Properties should not be public-mutable on the Realtime Connection class #452

QuintinWillison opened this issue Nov 29, 2022 · 1 comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Nov 29, 2022 •
edited by sync-by-unito bot
Loading

Looking at the docs for the Connection class...

For example errorReason is read-only because it's correctly implemented, yet id is read / write because it's incorrectly implemented.

Spotted while I was working on #432.

I fear that we may have other properties in other classes where the same 'lazy' implementation is in place.
@QuintinWillison QuintinWillison added the bug Something isn't working. It's clear that this does need to be fixed. label Nov 29, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Nov 29, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QuintinWillison